pnowojski commented on a change in pull request #11567: [FLINK-16645] Limit the
maximum backlogs in subpartitions
URL: https://github.com/apache/flink/pull/11567#discussion_r400335246
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartition.java
##########
@@ -375,4 +398,33 @@ void onConsumedSubpartition(int subpartitionIndex) {
private void checkInProduceState() throws IllegalStateException {
checkState(!isFinished, "Partition already finished.");
}
+
+ /**
+ * Check whether all subpartitions' backlogs are less than the
limitation of max backlogs, and make this partition
+ * available again if yes.
+ */
+ @GuardedBy("buffers")
Review comment:
That's not true. First of all this class can not relay on an implementation
detail of the `PipelinedSubpartition` (which is only one of two implementations
of `ResultSubpartition` class).
Secondly each `PipelinedSubpartition` has it's own `buffers` field, so the
updates here to `unavailableSubpartitionsCnt` are complete not synchronized.
Some simple solution might be to change `unavailableSubpartitionsCnt` to an
`AtomicLong`, but let me think about alternative solutions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
