pnowojski commented on a change in pull request #11567: [FLINK-16645] Limit the
maximum backlogs in subpartitions
URL: https://github.com/apache/flink/pull/11567#discussion_r400323498
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/NettyShuffleEnvironmentOptions.java
##########
@@ -174,6 +174,19 @@
" help relieve back-pressure caused by
unbalanced data distribution among the subpartitions. This value should be" +
" increased in case of higher round trip times
between nodes and/or larger number of machines in the cluster.");
+ /**
Review comment:
Could you also update in the L159 description a bit? I think after we
dropped the non credit based code path, it is a bit out of date.
> Number of exclusive network buffers to use for each outgoing/incoming
channel (subpartition/input channel) in the credit-based flow control model. It
should be configured at least 2 for good performance. 1 buffer is for receiving
in-flight data in the subpartition and 1 buffer is for parallel serialization.
Otherwise, as it is, it is a bit confusing with the new `max backlog`
description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
