aljoscha commented on a change in pull request #11622: 
[FLINK-16913][configuration, statebackend] Migrated StateBackends to use 
ReadableConfig instead of Configuration
URL: https://github.com/apache/flink/pull/11622#discussion_r402431794
 
 

 ##########
 File path: 
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBOptions.java
 ##########
 @@ -47,9 +48,10 @@
         * Choice of timer service implementation.
         */
        @Documentation.Section(Documentation.Sections.STATE_BACKEND_ROCKSDB)
-       public static final ConfigOption<String> TIMER_SERVICE_FACTORY = 
ConfigOptions
+       public static final ConfigOption<PriorityQueueStateType> 
TIMER_SERVICE_FACTORY = ConfigOptions
 
 Review comment:
   Also, weirdly named option: it's a "factory" but the type is an enum? 😅
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to