aljoscha commented on a change in pull request #11622:
[FLINK-16913][configuration, statebackend] Migrated StateBackends to use
ReadableConfig instead of Configuration
URL: https://github.com/apache/flink/pull/11622#discussion_r402432857
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendConfigTest.java
##########
@@ -792,8 +794,11 @@ public ColumnFamilyOptions
createColumnOptions(ColumnFamilyOptions currentOption
}
@Override
- public RocksDBOptionsFactory configure(Configuration
configuration) {
- this.backgroundJobs =
configuration.getInteger(BACKGROUND_JOBS_OPTION, DEFAULT_BACKGROUND_JOBS);
+ public RocksDBOptionsFactory configure(ReadableConfig
configuration) {
+ this.backgroundJobs = configuration.get(
+ ConfigOptions.key(BACKGROUND_JOBS_OPTION)
Review comment:
Nit: you could just turn the field into a `ConfigOption`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
