wuchong commented on a change in pull request #11663: [FLINK-16820][jdbc] 
support reading timestamp, data, and time in JDBCTableSource
URL: https://github.com/apache/flink/pull/11663#discussion_r405949916
 
 

 ##########
 File path: 
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/dialect/JDBCDialects.java
 ##########
 @@ -407,7 +407,6 @@ public int minTimestampPrecision() {
                        //  
PrimitiveArrayTypeInfo.BYTE_PRIMITIVE_ARRAY_TYPE_INFO in 
LegacyTypeInfoDataTypeConverter.
                        return Arrays.asList(
                                        LogicalTypeRoot.BINARY,
-                                       
LogicalTypeRoot.TIMESTAMP_WITH_LOCAL_TIME_ZONE,
 
 Review comment:
   If we don't support `TIMESTAMP_WITH_LOCAL_TIME_ZONE` for now, why remove it 
from the unsupported list?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to