bowenli86 commented on a change in pull request #11663: [FLINK-16820][jdbc]
support reading timestamp, data, and time in JDBCTableSource
URL: https://github.com/apache/flink/pull/11663#discussion_r406450408
##########
File path:
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/dialect/JDBCDialects.java
##########
@@ -407,7 +407,6 @@ public int minTimestampPrecision() {
//
PrimitiveArrayTypeInfo.BYTE_PRIMITIVE_ARRAY_TYPE_INFO in
LegacyTypeInfoDataTypeConverter.
return Arrays.asList(
LogicalTypeRoot.BINARY,
-
LogicalTypeRoot.TIMESTAMP_WITH_LOCAL_TIME_ZONE,
Review comment:
they are orthogonal. Flink's pg catalog/source/sink support timestamp with
local time zone, however it cannot be used due to limitations of legacy type
system. once we completely switch to new type system, it should be good to go
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
