kylemeow commented on a change in pull request #11639: [FLINK-16626][runtime]
Prevent REST handler from being closed more than once
URL: https://github.com/apache/flink/pull/11639#discussion_r406149904
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/AbstractHandler.java
##########
@@ -221,7 +227,12 @@ private void finalizeRequestProcessing(FileUploads
uploadedFiles) {
@Override
public final CompletableFuture<Void> closeAsync() {
- return FutureUtils.composeAfterwards(closeHandlerAsync(),
inFlightRequestTracker::awaitAsync);
+ if (isHandlerClosed.compareAndSet(false, true)) {
+ return
FutureUtils.composeAfterwards(closeHandlerAsync(),
inFlightRequestTracker::awaitAsync);
+ } else {
+ log.warn("The handler instance for {} had already been
closed, but another attempt at closing it was made.",
untypedResponseMessageHeaders.getTargetRestEndpointURL());
+ return CompletableFuture.completedFuture(null);
Review comment:
Hi @TisonKun , I have submitted a new commit which makes calls to closeAsync
return the same result despite of multiple calls (idempotent).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
