rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add
basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r407996739
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -523,15 +557,18 @@ public void onBuffer(Buffer buffer, int sequenceNumber,
int backlog) throws IOEx
return;
}
- if (expectedSequenceNumber != sequenceNumber) {
Review comment:
Why was this `if` moved outside of the `synchronized`?
Also, increment of `expectedSequenceNumber` below outside of the
`synchronized` looks suspicious. But this is an old change.
Am I missing something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
