rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add
basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r407990091
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -523,15 +557,18 @@ public void onBuffer(Buffer buffer, int sequenceNumber,
int backlog) throws IOEx
return;
}
- if (expectedSequenceNumber != sequenceNumber) {
- onError(new
BufferReorderingException(expectedSequenceNumber, sequenceNumber));
- return;
- }
-
wasEmpty = receivedBuffers.isEmpty();
receivedBuffers.add(buffer);
- recycleBuffer = false;
+
+ if (hasListener) {
+ if (buffer.isBuffer() &&
receivedCheckpointId < lastRequestedCheckpointId) {
+ notifyReceivedBuffer =
buffer.retainBuffer();
+ } else {
Review comment:
I'd prefer to see all writes to `notifyReceivedBuffer` in one place (so it
can be made `final` and easier to track).
For example (assuming we parse barrier later):
```
final Buffer notifyReceivedBuffer;
synchronized {
...
notifyReceivedBuffer = hasListener && buffer.isBuffer() &&
receivedCheckpointId < lastRequestedCheckpointId
? buffer.retainBuffer()
: null;
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
