twalthr commented on a change in pull request #11692: URL: https://github.com/apache/flink/pull/11692#discussion_r411158004
########## File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/connector/source/abilities/PeriodicWatermarkAssignerProvider.java ########## @@ -28,19 +28,14 @@ * generating watermarks in {@link ScanTableSource}. */ @PublicEvolving -public final class PeriodicWatermarkAssignerProvider extends SupportsWatermarkPushDown.WatermarkProvider { +public interface PeriodicWatermarkAssignerProvider extends SupportsWatermarkPushDown.WatermarkProvider { - private final AssignerWithPeriodicWatermarks<RowData> periodicAssigner; - - private PeriodicWatermarkAssignerProvider(AssignerWithPeriodicWatermarks<RowData> periodicAssigner) { - this.periodicAssigner = periodicAssigner; - } - - public static PeriodicWatermarkAssignerProvider of(AssignerWithPeriodicWatermarks<RowData> periodicAssigner) { - return new PeriodicWatermarkAssignerProvider(periodicAssigner); + /** + * Helper method for creating a static provider. + */ + static PeriodicWatermarkAssignerProvider of(AssignerWithPeriodicWatermarks<RowData> periodicAssigner) { Review comment: Yes, I agree. We can solve this using some internal class later. I will remove those methods. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org