zentol commented on a change in pull request #11983:
URL: https://github.com/apache/flink/pull/11983#discussion_r420605259
##########
File path:
flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/src/test/java/org/apache/flink/tests/util/kafka/SQLClientKafkaITCase.java
##########
@@ -106,11 +112,16 @@ public SQLClientKafkaITCase(String kafkaVersion, String
kafkaSQLVersion, String
}
@Before
- public void before() {
+ public void before() throws Exception {
+ downloadCache.before();
Path tmpPath = tmp.getRoot().toPath();
LOG.info("The current temporary path: {}", tmpPath);
this.sqlClientSessionConf =
tmpPath.resolve("sql-client-session.conf");
this.result = tmpPath.resolve("result");
+
+
apacheAvroJars.add(downloadCache.getOrDownload("https://repo1.maven.org/maven2/org/apache/avro/avro/1.8.2/avro-1.8.2.jar";,
tmpPath));
Review comment:
> Because flink-shaded-hadoop does not exist anymore in this change
Well duh, but hadoop is still on the classpath, no? Otherwise you're not
fulfilling the contract of the `Hadoop` category; if the test is still passing
then the category should be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
