rmetzger commented on a change in pull request #11983:
URL: https://github.com/apache/flink/pull/11983#discussion_r422927738
##########
File path: flink-end-to-end-tests/pom.xml
##########
@@ -153,6 +170,32 @@ under the License.
<build>
<plugins>
+ <plugin>
+ <artifactId>maven-resources-plugin</artifactId>
+ <!-- <version>3.1.0</version> -->
Review comment:
I think I copy pasted the plugin definition from somewhere and assumed
that the plugin version is centrally managed.
The other uses of the plugin are also defined without a version
```
--
flink-quickstart/pom.xml- <plugin>
flink-quickstart/pom.xml-
<groupId>org.apache.maven.plugins</groupId>
flink-quickstart/pom.xml:
<artifactId>maven-resources-plugin</artifactId>
flink-quickstart/pom.xml- <configuration>
flink-quickstart/pom.xml-
<useDefaultDelimiters>false</useDefaultDelimiters>
--
flink-table/flink-sql-parser-hive/pom.xml- <!-- adding
fmpp code gen -->
flink-table/flink-sql-parser-hive/pom.xml- <plugin>
flink-table/flink-sql-parser-hive/pom.xml:
<artifactId>maven-resources-plugin</artifactId>
flink-table/flink-sql-parser-hive/pom.xml-
<executions>
flink-table/flink-sql-parser-hive/pom.xml-
<execution>
--
flink-table/flink-sql-parser/pom.xml- <!-- adding
fmpp code gen -->
flink-table/flink-sql-parser/pom.xml- <plugin>
flink-table/flink-sql-parser/pom.xml:
<artifactId>maven-resources-plugin</artifactId>
flink-table/flink-sql-parser/pom.xml-
<executions>
flink-table/flink-sql-parser/pom.xml-
<execution>
--
flink-walkthroughs/pom.xml- <plugin>
flink-walkthroughs/pom.xml-
<groupId>org.apache.maven.plugins</groupId>
flink-walkthroughs/pom.xml:
<artifactId>maven-resources-plugin</artifactId>
flink-walkthroughs/pom.xml- <configuration>
flink-walkthroughs/pom.xml-
<useDefaultDelimiters>false</useDefaultDelimiters>
```
It doesn't seem that we are centrally managing the plugin versions. I would
propose to just remove the `<!-- <version>3.1.0</version> -->` line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
