dianfu commented on a change in pull request #11960:
URL: https://github.com/apache/flink/pull/11960#discussion_r421232892
##########
File path: flink-python/pyflink/table/tests/test_dependency.py
##########
@@ -179,9 +180,7 @@ def add_from_file(i):
self.assert_equals(actual, ["3,1", "4,2", "5,3"])
def test_set_environment(self):
- if getattr(os, "symlink", None) is None:
- self.skipTest("Symbolic link is not supported, skip testing
'test_set_python_exec'...")
-
+ unittest.skipIf(on_windows(), "Symbolic link is not supported on
Windows, skipping.")
Review comment:
`unittest.skipIf` could be used as a decorator. You could refer to
`test_coders.py` for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
