zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r422884550



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputChannel.java
##########
@@ -305,19 +311,18 @@ protected CheckpointBarrier 
parseCheckpointBarrierOrNull(Buffer buffer) throws I
 
        /**
         * A combination of a {@link Buffer} and a flag indicating availability 
of further buffers,
-        * and the backlog length indicating how many non-event buffers are 
available in the
-        * subpartition.
+        * and the backlog length indicating how many credits the subpartition.
         */
        public static final class BufferAndAvailability {
 
                private final Buffer buffer;
                private final boolean moreAvailable;
-               private final int buffersInBacklog;
+               private final int backlog;
 
-               public BufferAndAvailability(Buffer buffer, boolean 
moreAvailable, int buffersInBacklog) {
-                       this.buffer = checkNotNull(buffer);
+               public BufferAndAvailability(@Nullable Buffer buffer, boolean 
moreAvailable, int backlog) {

Review comment:
       We can also avoid introducing `nullable` buffer by this comment 
https://github.com/apache/flink/pull/11877/files#r422847423




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to