zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r424902024
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -418,8 +437,8 @@ public Buffer requestBuffer() {
*
* @param backlog The number of unsent buffers in the producer's sub
partition.
*/
- void onSenderBacklog(int backlog) throws IOException {
-
notifyBufferAvailable(bufferManager.requestFloatingBuffers(backlog +
initialCredit));
+ public void onSenderBacklog(int backlog) throws IOException {
Review comment:
nit: also adjust the javadoc of this method accordingly.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -327,6 +322,14 @@ public void notifyBufferAvailable(int numAvailableBuffers)
{
}
}
+ @Override
+ public void onCheckpointBarrier(CheckpointBarrier barrier) {
Review comment:
make it only private method inside `RemoteInputChannel`, because it is
never used outside.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
