zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r424911901
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/BufferManager.java
##########
@@ -129,7 +132,6 @@ private boolean shouldContinueRequest(BufferPool
bufferPool) {
*/
void requestExclusiveBuffers() throws IOException {
Collection<MemorySegment> segments =
globalPool.requestMemorySegments();
- checkArgument(!segments.isEmpty(), "The number of exclusive
buffers per channel should be larger than 0.");
Review comment:
Got it. So do you think we add the `if (initialCredit > 0)` before
calling this method inside `RemoteInputChannel#assignExclusiveSegments`? Just
for not necessary to `synchronized` below for empty segments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
