rkhachatryan commented on a change in pull request #8693:
URL: https://github.com/apache/flink/pull/8693#discussion_r425872130
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -182,7 +181,7 @@
protected final TimerService timerService;
/** The currently active background materialization threads. */
- private final CloseableRegistry cancelables = new CloseableRegistry();
+ private final AsyncCheckpointRunnableRegistry cancelables = new
AsyncCheckpointRunnableRegistry();
Review comment:
I think that `SubtaskCheckpointCoordinator` shouldn't delegate *its*
responsibility of maintaining _its_ runnables to
`StreamTask.closeableRegistry`. Changing the names only masquerades it.
Using the same registry creates unnecessary connection, making it more
difficult to change `StreamTask` (for example, to remove registry type).
At runtime, I guess behavior is more or less the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
