rkhachatryan commented on a change in pull request #8693:
URL: https://github.com/apache/flink/pull/8693#discussion_r425862033
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java
##########
@@ -183,6 +235,42 @@ public void notifyCheckpointComplete(long checkpointId,
OperatorChain<?, ?> oper
env.getTaskStateManager().notifyCheckpointComplete(checkpointId);
}
+ @Override
+ public void notifyCheckpointAborted(long checkpointId, OperatorChain<?,
?> operatorChain, Supplier<Boolean> isRunning) throws Exception {
+
+ if (isRunning.get()) {
+ LOG.debug("Notification of aborted checkpoint for task
{}", taskName);
+ // only happens when the task always received
checkpoints to abort but never trigger or executing.
+ if (abortedCheckpointIds.size() >=
maxRecordAbortedCheckpoints) {
+ abortedCheckpointIds.pollFirst();
+ }
+
+ channelStateWriter.abort(checkpointId, new
NotifiedCheckpointAbortedException(checkpointId));
Review comment:
In that case, `CheckpointBarrierHandler` will call abort on the next
barrier.
Though I don't think it's possible that task skips the cancellation marker.
edit: just to clarify, `channelStateWriter` should by in sync with barrier
handlers. As you mentioned
[below](https://github.com/apache/flink/pull/8693#issuecomment-629017420), they
aren't updated in this PR. So `channelStateWriter` also shouldn't be affected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
