becketqin commented on a change in pull request #12137:
URL: https://github.com/apache/flink/pull/12137#discussion_r426157226



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java
##########
@@ -186,10 +188,18 @@ private void maybeHandleTaskFailure(final 
TaskExecutionState taskExecutionState,
 
        private void handleTaskFailure(final ExecutionVertexID 
executionVertexId, @Nullable final Throwable error) {
                setGlobalFailureCause(error);
+               notifyCoordinatorsAboutTaskFailure(executionVertexId, error);

Review comment:
       Sounds good to me. Maybe we can just remove it in this PR. The code is 
here:
   
https://github.com/apache/flink/blob/6f64213dbdfd0b1e75f503007dd026162881c9c7/flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorContext.java#L252




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to