guoweiM commented on pull request #12132:
URL: https://github.com/apache/flink/pull/12132#issuecomment-629779232


   Hi, @aljoscha 
   I could not restore bucket state through reading the snapshot of v1 in my 
local. I think one reason is that these snapshots contain absolute paths. such 
as
   
   > Expected 
:/Users/maguowei/project/flink.guowei/flink-streaming-java/src/test/resources/bucket-state-migration-test/only-in-progress-v2/bucket/test-bucket/
   Actual   
:/Users/aljoscha/Dev/flink/flink-streaming-java/src/test/resources/bucket-state-migration-test/only-in-progress-v2/bucket/test-bucket/
   <
   
   So I change the `BucketStateSerializerTest`
   1. `prepareDeserializationEmpty`& `prepareDeserializationOnlyInProgress` & 
`prepareDeserializationFull` & `prepareDeserializationNullInProgress` to 
produce only relative path.  So I think we should use the new version to 
produce the snapshot file.
   2. In order to avoid the test regression. I generated two template 
directories for `testSerializationNullInProgress`&`testSerializationFull` to 
test recovery&commit. Each test would copy the template directory to the 
temporary directory for testing. Delete after the temporary directory test is 
complete.
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to