JingsongLi commented on pull request #12132: URL: https://github.com/apache/flink/pull/12132#issuecomment-629875114
I had a wrong understanding before. I'm very sorry it's too abrupt. Thanks you for continuing working. You are doing right things. I see your commit: "Turn BucketStateSerializerTest into an upgrade test". +1 for the upgrade/migration test be added separately before the changes to the serializer. This is the best way to upgrade the serializer, so as to ensure that the generated file must be of the previous version, without accidentally generating code that seems to work. And yes for special `RecoverableWriter`, we should find a way to solve absolute path problem and not mock critical path and test what we need test. For the raw-use of generic types, I think we should avoid using `? extends xx` as a field or return type as much as possible. Such code can easily lead to uncomfortable generics, and often we have no way to solve it. After carefully reviewing your comments,, I learned a lot. Thank you. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
