aljoscha commented on pull request #12132:
URL: https://github.com/apache/flink/pull/12132#issuecomment-630022206


   No hard feeling, I hope! 😃
   
   I managed to make my version of the test also work, by allowing relative 
paths for the local filesystem: 
https://github.com/aljoscha/flink/commits/pr-12132-file-sink.
   
   @guoweiM I agree with you that actually testing the file moving might be a 
better approach (the only thing I didn't like there was the manual file 
moving/cleanup but maybe that's ok. Could you rename the commit that changes 
the test to `[FLINK-17593] Turn BucketStateSerializerTest into an upgrade 
test`. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to