rkhachatryan commented on a change in pull request #8693:
URL: https://github.com/apache/flink/pull/8693#discussion_r427254149
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java
##########
@@ -126,6 +162,15 @@ public ChannelStateWriter getChannelStateWriter() {
return channelStateWriter;
}
+ @VisibleForTesting
+ int getAbortedCheckpointSize() {
+ return abortedCheckpointIds.size();
+ }
+
+ private boolean checkpointAlreadyAborted(long checkpointId) {
Review comment:
By convention, `isXxx` should be used for boolean getters.
I think it's always good to give self-explaining names to methods to prevent
surprises and looking into their code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
