Github user stefanobaghino commented on a diff in the pull request: https://github.com/apache/flink/pull/1536#discussion_r50400122 --- Diff: flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/clustering/KMeans.scala --- @@ -104,36 +105,52 @@ object KMeans { } - private def parseParameters(programArguments: Array[String]): Boolean = { - if (programArguments.length > 0) { + private val POINTS_PATH_OPTION: Option = + new Option("points").alt("P").help("The path to the input points") + private val CENTERS_PATH_OPTION: Option = + new Option("centroids").alt("C").help("The path to the input centroids") + private val OUTPUT_PATH_OPTION: Option = + new Option("output").alt("O").help("The path where the output will be written") + private val NUM_ITERATIONS_OPTION: Option = + new Option("iterations").alt("I").help("The number of iteration performed by the K-Means algorithm") + + @throws(classOf[RequiredParametersException]) --- End diff -- Should I ignore this remark, too? You can find a more detailed explanation of why I kept the checked exceptions for the `add` calls in the PR description.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---