Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1536#discussion_r50401269
--- Diff:
flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java
---
@@ -291,31 +297,54 @@ public Centroid map(Tuple3<Integer, Point, Long>
value) {
private static String centersPath = null;
private static String outputPath = null;
private static int numIterations = 10;
-
- private static boolean parseParameters(String[] programArguments) {
-
- if(programArguments.length > 0) {
- // parse input arguments
+
+ private static final Option POINTS_PATH_OPTION =
+ new Option("points").alt("P").help("The path to the input
points");
+ private static final Option CENTERS_PATH_OPTION =
+ new Option("centroids").alt("C").help("The path to the input
centroids");
+ private static final Option OUTPUT_PATH_OPTION =
+ new Option("output").alt("O").help("The path where the output
will be written");
+ private static final Option NUM_ITERATIONS_OPTION =
+ new Option("iterations").alt("I").help("The number of iteration
performed by the K-Means algorithm");
+
+ private static boolean parseParameters(final ParameterTool params)
throws RequiredParametersException {
--- End diff --
I would actually remove the `parseParameters` method
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
