JingsongLi commented on a change in pull request #12323:
URL: https://github.com/apache/flink/pull/12323#discussion_r430861320
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/FileSystemOptions.java
##########
@@ -132,12 +133,12 @@
public static final ConfigOption<String> SINK_PARTITION_COMMIT_TRIGGER =
key("sink.partition-commit.trigger")
.stringType()
- .defaultValue("partition-time")
+ .defaultValue("process-time")
.withDescription("Trigger type for
partition commit:" +
Review comment:
```
'process-time': use processing time, if 'current time' > 'partition creation
time' + 'delay', will commit the partition.
'partition-time': extract time from partition, if 'current event time' >
'time from partition values' + 'delay', will commit the partition.
```
`time from partition values` is a kind of event time.
`partition creation time` is from processing time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
