JingsongLi commented on a change in pull request #12323:
URL: https://github.com/apache/flink/pull/12323#discussion_r430936699
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/FileSystemOptions.java
##########
@@ -132,12 +133,12 @@
public static final ConfigOption<String> SINK_PARTITION_COMMIT_TRIGGER =
key("sink.partition-commit.trigger")
.stringType()
- .defaultValue("partition-time")
+ .defaultValue("process-time")
.withDescription("Trigger type for
partition commit:" +
Review comment:
After some offline discussion, I think `partition-time` is more direct.
Adjust the comments further.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
