dianfu commented on a change in pull request #12370:
URL: https://github.com/apache/flink/pull/12370#discussion_r432910820
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/batch/BatchExecPythonCalc.scala
##########
@@ -61,20 +60,10 @@ class BatchExecPythonCalc(
"BatchExecPythonCalc",
getConfig(planner.getExecEnv, planner.getTableConfig))
- ExecNode.setManagedMemoryWeight(
- ret, getPythonWorkerMemory(planner.getTableConfig.getConfiguration))
- }
-
- private def getPythonWorkerMemory(config: Configuration): Long = {
- val clazz = loadClass("org.apache.flink.python.PythonOptions")
- val pythonFrameworkMemorySize = MemorySize.parse(
- config.getString(
- clazz.getField("PYTHON_FRAMEWORK_MEMORY_SIZE").get(null)
- .asInstanceOf[ConfigOption[String]]))
- val pythonBufferMemorySize = MemorySize.parse(
- config.getString(
- clazz.getField("PYTHON_DATA_BUFFER_MEMORY_SIZE").get(null)
- .asInstanceOf[ConfigOption[String]]))
- pythonFrameworkMemorySize.add(pythonBufferMemorySize).getBytes
+ if (usingManagedMemory(planner.getTableConfig.getConfiguration)) {
Review comment:
Yes, you are right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
