zhuzhurk commented on a change in pull request #12370:
URL: https://github.com/apache/flink/pull/12370#discussion_r433608507



##########
File path: flink-python/src/main/java/org/apache/flink/python/PythonOptions.java
##########
@@ -148,4 +149,17 @@
                        "The priority is as following: 1. the configuration 
'python.client.executable' defined in " +
                        "the source code; 2. the environment variable 
PYFLINK_EXECUTABLE; 3. the configuration " +
                        "'python.client.executable' defined in 
flink-conf.yaml");
+
+       /**
+        * Whether the memory used by the Python framework is managed memory.
+        */
+       public static final ConfigOption<Boolean> USE_MANAGED_MEMORY = 
ConfigOptions

Review comment:
       How about making it an internal config (exclude from documents) since 
using managed memory does not work well in all cases? I feel that normal users 
will not need to change it. Correct me if I'm wrong here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to