GitHub user ramkrish86 opened a pull request:

    https://github.com/apache/flink/pull/1553

    FLINK-3179 Combiner is not injected if Reduce or GroupReduce input is 
explicitly partitioned (Ram)

    Followed the guidance given in the description in order to fix this. Is the 
approach correct here?  Also using this to learn the code. 
    Once we see that a partition node is the input of a reduce node or group 
reduce node -  we try to inject the combiner to the source node (the data 
source node) and the reducer node will take the actual partition node as the 
input. 
    So now the structure would be DataSource->Combine->Partition->Reduce. 
    Suggestions and feedback welcome as am not sure if I have covered all the 
cases here. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ramkrish86/flink FLINK-3179

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1553.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1553
    
----
commit ccf6e18418ac9cae1c27a5ff4399ea188b03bc0b
Author: ramkrishna <[email protected]>
Date:   2016-01-27T16:27:17Z

    FLINK-3179 Combiner is not injected if Reduce or GroupReduce input is
    explicitly partitioned (Ram)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to