Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1553#discussion_r51259067
  
    --- Diff: 
flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/GroupReduceWithCombineProperties.java
 ---
    @@ -102,36 +107,72 @@ public SingleInputPlanNode instantiate(Channel in, 
SingleInputNode node) {
                                                                                
        DriverStrategy.SORTED_GROUP_REDUCE, this.keyList);
                } else {
                        // non forward case. all local properties are killed 
anyways, so we can safely plug in a combiner
    --- End diff --
    
    The `else` branch will not be entered if the GroupReduce's predecessor is a 
Partition operator.
    You need to add an `if else` branch to the condition.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to