zentol commented on a change in pull request #12490:
URL: https://github.com/apache/flink/pull/12490#discussion_r435529933
##########
File path: docs/ops/deployment/docker.md
##########
@@ -215,17 +241,16 @@ The `flink-conf.yaml` file must have write permission so
that the Docker entry p
### Using plugins
As described in the [plugins]({{ site.baseurl }}/ops/plugins.html)
documentation page: in order to use plugins they must be
-copied to the correct location in the Flink installation for them to work.
+copied to the correct location in the Flink installation in the Docker
container for them to work.
-If you want to enable plugins provided with Flink, you can pass the
environment variable `ENABLE_BUILT_IN_PLUGINS`
-when you run the Flink image.
-The `ENABLE_BUILT_IN_PLUGINS` should contain a list of plugin jar file names
separated by `;`.
+If you want to enable plugins provided with Flink (in the `opt/` directory of
the Flink distribution), you can pass the environment variable
`ENABLE_BUILT_IN_PLUGINS` when you run the Flink image.
+The `ENABLE_BUILT_IN_PLUGINS` should contain a list of plugin jar file names
separated by `;`. A valid plugin name is for example
`flink-s3-fs-hadoop-{{site.version}}.jar`
- ```sh
+```sh
docker run \
- --env ENABLE_BUILT_IN_PLUGINS=flink-plugin1.jar;flink-plugin2.jar \
- flink:{% if site.is_stable
%}{{site.version}}-scala{{site.scala_version_suffix}}{% else %}latest{% endif
%} <jobmanager|standalone-job|taskmanager>
- ```
+ --env ENABLE_BUILT_IN_PLUGINS=flink-plugin1.jar;flink-plugin2.jar \
Review comment:
indentation seems different to other sections
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
