zentol commented on a change in pull request #12490:
URL: https://github.com/apache/flink/pull/12490#discussion_r435530729
##########
File path: docs/ops/deployment/docker.md
##########
@@ -105,18 +126,23 @@ To make the **job artifacts available** locally in the
container, you can
the *Flink Master* and *TaskManagers*:
```sh
+ FLINK_PROPERTIES="jobmanager.rpc.address: jobmanager"
+ docker network create flink-network
+
docker run \
--mount
type=bind,src=/host/path/to/job/artifacts1,target=/opt/flink/usrlib/artifacts1 \
--mount
type=bind,src=/host/path/to/job/artifacts2,target=/opt/flink/usrlib/artifacts2 \
+ --rm --env FLINK_PROPERTIES="${FLINK_PROPERTIES}" --name=jobmanager
--network flink-network \
Review comment:
I'd prefer having everything on separate lines
##########
File path: docs/ops/deployment/docker.md
##########
@@ -73,18 +73,39 @@ The next chapters describe how to start a single Flink
Docker container for vari
### Start a Session Cluster
A *Flink Session cluster* can be used to run multiple jobs. Each job needs to
be submitted to the cluster after it has been deployed.
-To deploy a *Flink Session cluster* with Docker, you need to start a *Flink
Master* container:
+To deploy a *Flink Session cluster* with Docker, you need to start a *Flink
Master* container. To enable communication between the containers, we first set
a required Flink configuration property and create a network:
+```sh
+FLINK_PROPERTIES="jobmanager.rpc.address: jobmanager"
+docker network create flink-network
+```
+
+Then we launch the JobManager:
```sh
-docker run flink:{% if site.is_stable
%}{{site.version}}-scala{{site.scala_version_suffix}}{% else %}latest{% endif
%} jobmanager
+docker run \
+ --rm \
+ --name=jobmanager \
+ --network flink-network \
+ -p 8081:8081 \
+ --env FLINK_PROPERTIES="${FLINK_PROPERTIES}" \
+ flink:{% if site.is_stable
%}{{site.version}}-scala{{site.scala_version_suffix}}{% else %}latest{% endif
%} jobmanager
```
and one or more *TaskManager* containers:
```sh
-docker run flink:{% if site.is_stable
%}{{site.version}}-scala{{site.scala_version_suffix}}{% else %}latest{% endif
%} taskmanager
+docker run \
+ --rm \
+ --name=taskmanager \
+ --network flink-network \
+ --env FLINK_PROPERTIES="${FLINK_PROPERTIES}" \
+ flink:{% if site.is_stable
%}{{site.version}}-scala{{site.scala_version_suffix}}{% else %}latest{% endif
%} taskmanager
```
+You can now access the Flink Webfrontend on
[localhost:8081](http://localhost:8081/#/overview) or submit jobs like this
`./bin/flink run ./examples/streaming/TopSpeedWindowing.jar`.
Review comment:
This is the wrong place for this information. A user jumping straight to
the job cluster docs will not see it.
##########
File path: docs/ops/deployment/docker.md
##########
@@ -73,18 +73,39 @@ The next chapters describe how to start a single Flink
Docker container for vari
### Start a Session Cluster
A *Flink Session cluster* can be used to run multiple jobs. Each job needs to
be submitted to the cluster after it has been deployed.
-To deploy a *Flink Session cluster* with Docker, you need to start a *Flink
Master* container:
+To deploy a *Flink Session cluster* with Docker, you need to start a *Flink
Master* container. To enable communication between the containers, we first set
a required Flink configuration property and create a network:
+```sh
+FLINK_PROPERTIES="jobmanager.rpc.address: jobmanager"
+docker network create flink-network
+```
+
+Then we launch the JobManager:
```sh
-docker run flink:{% if site.is_stable
%}{{site.version}}-scala{{site.scala_version_suffix}}{% else %}latest{% endif
%} jobmanager
+docker run \
+ --rm \
+ --name=jobmanager \
+ --network flink-network \
+ -p 8081:8081 \
+ --env FLINK_PROPERTIES="${FLINK_PROPERTIES}" \
+ flink:{% if site.is_stable
%}{{site.version}}-scala{{site.scala_version_suffix}}{% else %}latest{% endif
%} jobmanager
```
and one or more *TaskManager* containers:
```sh
-docker run flink:{% if site.is_stable
%}{{site.version}}-scala{{site.scala_version_suffix}}{% else %}latest{% endif
%} taskmanager
+docker run \
+ --rm \
+ --name=taskmanager \
+ --network flink-network \
+ --env FLINK_PROPERTIES="${FLINK_PROPERTIES}" \
+ flink:{% if site.is_stable
%}{{site.version}}-scala{{site.scala_version_suffix}}{% else %}latest{% endif
%} taskmanager
```
+You can now access the Flink Webfrontend on
[localhost:8081](http://localhost:8081/#/overview) or submit jobs like this
`./bin/flink run ./examples/streaming/TopSpeedWindowing.jar`.
+
+We recommend using [Docker
Compose](docker.html#session-cluster-with-docker-compose) or [Docker
Swarm](docker.html#session-cluster-with-docker-swarm) for deploying Flink as a
Session Cluster to ease system configuration.
Review comment:
same as above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
