KarmaGYZ commented on a change in pull request #12619:
URL: https://github.com/apache/flink/pull/12619#discussion_r439900572
##########
File path:
flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBaseTest.java
##########
@@ -586,6 +600,27 @@ public void process(String element, RuntimeContext ctx,
RequestIndexer indexer)
}
}
+ private static class SimpleClosableSinkFunction<String> implements
ElasticsearchSinkFunction<String> {
Review comment:
Maybe `TestingClosableSinkFunction`? Not quite sure about this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
