Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1585#discussion_r51870482
  
    --- Diff: 
flink-java/src/main/java/org/apache/flink/api/java/operators/SortPartitionOperator.java
 ---
    @@ -89,6 +100,22 @@ public SortPartitionOperator(DataSet<T> dataSet, String 
sortField, Order sortOrd
                return this;
        }
     
    +   /**
    +    * Appends an additional sort order with the specified field in the 
specified order to the
    +    * local partition sorting of the DataSet.
    +    *
    +    * @param keyExtractor The KeySelector function which extracts the key 
value of the additional
    +    *                     sort order of the local partition sorting.
    +    * @param order The order of the additional sort order of the local 
partition sorting.
    +    * @return The DataSet with sorted local partitions.
    +    */
    +   public <K> SortPartitionOperator<T> sortPartition(KeySelector<T, K> 
keyExtractor, Order order) {
    --- End diff --
    
    I would not allow chaining.
    In addition, we must make sure that `ExpressionKeys` and 
`SelectorFunctionKeys` are not mixed. So you can either use a single key 
selector or one or more expression keys.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to