Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1585#issuecomment-180224231
@fhueske I addressed your comments.
To reduce modifying original code, I added some variables for key selector
only. But this make the source code quite messy. I would like to refactor
`SortPartitionOperator` like following:
* Preserve key informations and sort orders as `List<Keys>` and
`List<Order>` object.
* We have to create a list because users can chain expression keys.
* Check whether given field is sortable or not in constructors and
`sortPartition` method in `SortPartitionOperator`
* Remove `sortKeyPositions`, `sortOrders`, `getFlatFields` and
`appendSorting`
* When `translateToDataFlow` method is called, the method fetches key
positions from preserved key objects and creates operators.
Does this make sense?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
