[
https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15132369#comment-15132369
]
ASF GitHub Bot commented on FLINK-2021:
---------------------------------------
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-179859441
I just checked out your pull request locally and looked through it.
I think the following things need to be fixed before we can merge it:
- Squash the 60+ commits in the PR into one
- Fix the failing tests
- Adopt also the "http://localhost:4000/apis/batch/examples.html"; page.
- If @fhueske agrees, do not use a `get*` (for example
`TwitterStream.getTextDataStream`) method if there is only one input. I'm okay
with using those methods for examples with input >= 2.
> Rework examples to use ParameterTool
> ------------------------------------
>
> Key: FLINK-2021
> URL: https://issues.apache.org/jira/browse/FLINK-2021
> Project: Flink
> Issue Type: Improvement
> Components: Examples
> Affects Versions: 0.9
> Reporter: Robert Metzger
> Priority: Minor
> Labels: starter
>
> In FLINK-1525, we introduced the {{ParameterTool}}.
> We should port the examples to use the tool.
> The examples could look like this (we should maybe discuss it first on the
> mailing lists):
> {code}
> public static void main(String[] args) throws Exception {
> ParameterTool pt = ParameterTool.fromArgs(args);
> boolean fileOutput = pt.getNumberOfParameters() == 2;
> String textPath = null;
> String outputPath = null;
> if(fileOutput) {
> textPath = pt.getRequired("input");
> outputPath = pt.getRequired("output");
> }
> // set up the execution environment
> final ExecutionEnvironment env =
> ExecutionEnvironment.getExecutionEnvironment();
> env.getConfig().setUserConfig(pt);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
