[
https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15132602#comment-15132602
]
ASF GitHub Bot commented on FLINK-2021:
---------------------------------------
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-179949096
Following your suggestions, thanks.
* squash: should I squash the commits coming from the review as well?
* tests: I thought it was about some Travis configuration on our fork, I'll
have to look into it
* docs: thanks for pointing out the documentation, I missed it!
* get: I'm not sure about it, I think it would be cleaner logically but it
would make the `params` checking a little bit heavier on the reader — I can
work on that but I'd wrap the parameter checking in a `checkParameters` method
that is used for the initial checking and the one in the `get*` methods, would
that work for you?
> Rework examples to use ParameterTool
> ------------------------------------
>
> Key: FLINK-2021
> URL: https://issues.apache.org/jira/browse/FLINK-2021
> Project: Flink
> Issue Type: Improvement
> Components: Examples
> Affects Versions: 0.9
> Reporter: Robert Metzger
> Priority: Minor
> Labels: starter
>
> In FLINK-1525, we introduced the {{ParameterTool}}.
> We should port the examples to use the tool.
> The examples could look like this (we should maybe discuss it first on the
> mailing lists):
> {code}
> public static void main(String[] args) throws Exception {
> ParameterTool pt = ParameterTool.fromArgs(args);
> boolean fileOutput = pt.getNumberOfParameters() == 2;
> String textPath = null;
> String outputPath = null;
> if(fileOutput) {
> textPath = pt.getRequired("input");
> outputPath = pt.getRequired("output");
> }
> // set up the execution environment
> final ExecutionEnvironment env =
> ExecutionEnvironment.getExecutionEnvironment();
> env.getConfig().setUserConfig(pt);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
