Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r52488669
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/MemoryHashTableTest.java
---
@@ -100,340 +101,371 @@
@Test
public void testDifferentProbers() {
final int NUM_MEM_PAGES = 32 * NUM_PAIRS / PAGE_SIZE;
-
- AbstractMutableHashTable<IntPair> table = new
CompactingHashTable<IntPair>(serializer, comparator, getMemory(NUM_MEM_PAGES,
PAGE_SIZE));
-
+ testDifferentProbersCore(new CompactingHashTable<>(serializer,
comparator, getMemory(NUM_MEM_PAGES, PAGE_SIZE)), NUM_MEM_PAGES);
--- End diff --
OK, I'll split the top-level methods into two methods, and move these to
different classes. However, the core of the tests can remain shared, right?
For example, I would split `testBuildAndRetrieve` to two methods, and move
these to different classes, but both of them would still call the same
`testBuildAndRetrieveCore`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
