Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r52605362
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/RandomAccessInputView.java
---
@@ -45,9 +45,12 @@ public RandomAccessInputView(ArrayList<MemorySegment>
segments, int segmentSize)
{
this(segments, segmentSize, segmentSize);
}
-
+
+ /**
+ * Warning: setReadPosition has to be called before reading.
+ */
public RandomAccessInputView(ArrayList<MemorySegment> segments, int
segmentSize, int limitInLastSegment) {
--- End diff --
I tried this, but it turned out that there is no nice way to do it, because
the two constructors would have the same parameters, so I had to add a dummy
parameter. (See
https://github.com/apache/flink/commit/508ce22c3167dc6e6e2a4a6b9776b6c79e62698f)
Do you think that this ugly solution is worth it, or should I revert to the
original?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
