zhijiangW commented on a change in pull request #2:
URL: https://github.com/apache/flink-benchmarks/pull/2#discussion_r477008616



##########
File path: 
src/main/java/org/apache/flink/benchmark/RemoteChannelThroughputBenchmark.java
##########
@@ -48,6 +49,9 @@
 
     private MiniCluster miniCluster;
 
+    @Param({"AlignedCheckpoint", "UnalignedCheckpoint"})

Review comment:
       Actually I tried the shorten name in early version, but i am wondering 
it might confuse external users, so i changed to the semantic name finally. 
Anyway, i have no preference here and will change it as you suggested. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to