pnowojski commented on a change in pull request #2:
URL: https://github.com/apache/flink-benchmarks/pull/2#discussion_r477276471
##########
File path:
src/main/java/org/apache/flink/benchmark/UnalignedCheckpointTimeBenchmark.java
##########
@@ -42,17 +43,22 @@
import static java.util.concurrent.TimeUnit.HOURS;
+/**
+ * The benchmark for measuring the time taken to finish the configured number
of
+ * unaligned checkpoints.
+ */
@OutputTimeUnit(HOURS)
Review comment:
NIT: maybe per minute? it doesn't matter if the result is reported in
similarly sized values as in other benchmarks, while on the other hand `number
of checkpoints/minute` seems a bit more natural?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
