[
https://issues.apache.org/jira/browse/FLINK-19216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-19216.
------------------------------------
Resolution: Not A Problem
Checking for numbers first is important to find negative numbers.
This is also mentioned in the comment in the second if block.
{{// the argument cannot be a negative number because we checked earlier}}
> Reduce the duplicate argument check
> -----------------------------------
>
> Key: FLINK-19216
> URL: https://issues.apache.org/jira/browse/FLINK-19216
> Project: Flink
> Issue Type: Improvement
> Components: API / Core
> Reporter: darion yaphet
> Priority: Major
> Labels: pull-request-available
>
> Whether the parameter is a number or not, we will put it into the map and
> then increment the index. So maybe I can merge them into one .
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
