azagrebin commented on a change in pull request #13355:
URL: https://github.com/apache/flink/pull/13355#discussion_r488116191
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
##########
@@ -157,7 +158,7 @@
private final FatalErrorHandler fatalErrorHandler;
- private final ClassLoader userCodeLoader;
+ private final UserCodeClassLoader userCodeLoader;
Review comment:
We could add another default method to `InitializeOnMaster` which falls
back to the existing method.
There is also some checkpoint global completion hook on JM side.
Generally, I believe running of user code in JM side does not differ too
much from running in TM and can lead to similar metaspace leaks.
wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
