rmetzger commented on a change in pull request #13355:
URL: https://github.com/apache/flink/pull/13355#discussion_r488417234
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
##########
@@ -157,7 +158,7 @@
private final FatalErrorHandler fatalErrorHandler;
- private final ClassLoader userCodeLoader;
+ private final UserCodeClassLoader userCodeLoader;
Review comment:
Yes, user code running on the JobManager can cause exactly the same
problems.
But I'm not sure if it makes sense to provide the shutdown hooks at these
locations in the JobManager right now: We currently have no use-case for them.
This change here is done for the Kinesis producer, which runs on the
TaskManagers only.
I would vote for introducing this new API in the JobManager once we need it
(it is a fairly simple change based on this one, but we can keep the complexity
lower for now)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
