Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1553#issuecomment-185170325
Hi @ramkrish86, thanks for the update.
In addition to my comments inline we also need to extend the `ReduceITCase`.
Also we must take care of the case where the result of the partition
operator goes into more than one function. Consider the following case:
```
/--fwd--> [Reduce]
[Input] --shuffle--> [Partitioner] -<
\--fwd--> [Map]
```
which should be translated to:
```
/--fwd--> [Combine] --shuffle--> [Partitioner] --fwd--> [Reduce]
[Input] --<
\--shuffle--> [Partitioner] --fwd--> [Map]
```
Both translation tests need to be extended to cover this case.
Thanks, Fabian
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
