Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1553#discussion_r53151777
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/GroupReduceWithCombineProperties.java
---
@@ -87,19 +92,39 @@ public DriverStrategy getStrategy() {
return DriverStrategy.SORTED_GROUP_REDUCE;
}
- @Override
public SingleInputPlanNode instantiate(Channel in, SingleInputNode
node) {
if (in.getShipStrategy() == ShipStrategyType.FORWARD) {
// adjust a sort (changes grouping, so it must be for
this driver to combining sort
- if (in.getLocalStrategy() == LocalStrategy.SORT) {
- if
(!in.getLocalStrategyKeys().isValidUnorderedPrefix(this.keys)) {
- throw new RuntimeException("Bug:
Inconsistent sort for group strategy.");
+ if(in.getSource().getOptimizerNode() instanceof
PartitionNode) {
--- End diff --
I think we can move the code of this branch into a method called
`injectCombinerBeforePartitioner()`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
