[
https://issues.apache.org/jira/browse/FLINK-3554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15173757#comment-15173757
]
ASF GitHub Bot commented on FLINK-3554:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1750#discussion_r54566693
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StoppableStreamSource.java
---
@@ -41,7 +41,14 @@ public StoppableStreamSource(SRC sourceFunction) {
super(sourceFunction);
}
+ /**
+ * Marks the source a stopped and calls {@link
StoppableFunction#stop()} on the user function.
+ */
public void stop() {
+ // important: marking the source as stopped has to happen
before the function is stopped.
+ // the flag that tracks this status is volatile, to the memory
model also guarantees
--- End diff --
typo in comment: to => so
> Bounded sources should emit a Max Watermark when they are done
> --------------------------------------------------------------
>
> Key: FLINK-3554
> URL: https://issues.apache.org/jira/browse/FLINK-3554
> Project: Flink
> Issue Type: Bug
> Components: Streaming
> Affects Versions: 1.0.0
> Reporter: Stephan Ewen
> Priority: Critical
> Fix For: 1.0.1
>
>
> For proper event time support in bounded sources, these sources should emit a
> final watermark before shutting down.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
