[
https://issues.apache.org/jira/browse/FLINK-3554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15173761#comment-15173761
]
ASF GitHub Bot commented on FLINK-3554:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1750#discussion_r54566902
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/SourceFunctionTest.java
---
@@ -61,9 +61,9 @@ public void generateSequenceTest() throws Exception {
assertEquals(expectedList, actualList);
}
- @Test
- public void socketTextStreamTest() throws Exception {
- // TODO: does not work because we cannot set the internal
socket anymore
+// TODO: does not work because we cannot set the internal socket anymore
+// @Test
+// public void socketTextStreamTest() throws Exception {
--- End diff --
Why not removing this test?
> Bounded sources should emit a Max Watermark when they are done
> --------------------------------------------------------------
>
> Key: FLINK-3554
> URL: https://issues.apache.org/jira/browse/FLINK-3554
> Project: Flink
> Issue Type: Bug
> Components: Streaming
> Affects Versions: 1.0.0
> Reporter: Stephan Ewen
> Priority: Critical
> Fix For: 1.0.1
>
>
> For proper event time support in bounded sources, these sources should emit a
> final watermark before shutting down.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
