[
https://issues.apache.org/jira/browse/FLINK-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175430#comment-15175430
]
ASF GitHub Bot commented on FLINK-3474:
---------------------------------------
Github user ChengXiangLi commented on the pull request:
https://github.com/apache/flink/pull/1746#issuecomment-191186632
Hi, @fhueske , i've update the PR based on your comments, except object
reusing in `AggregateGroupCombineFunction`. I found `GroupReduceOperator`
would transform it into `CombineToGroupCombineWrapper` which does not implement
a rich user function. so we can not initiate the reusing object in `open()`. I
think we need add a `RichCombineToGroupCombineWrapper` which used to wrap rich
combinable GroupReduceFunction like 'AggregateGroupCombineFunction'. what do
you think?
> Partial aggregate interface design and sort-based implementation
> ----------------------------------------------------------------
>
> Key: FLINK-3474
> URL: https://issues.apache.org/jira/browse/FLINK-3474
> Project: Flink
> Issue Type: Sub-task
> Components: Table API
> Reporter: Chengxiang Li
> Assignee: Chengxiang Li
>
> The scope of this sub task includes:
> # Partial aggregate interface.
> # Simple aggregate function implementation, such as SUM/AVG/COUNT/MIN/MAX.
> # DataSetAggregateRule which translate logical calcite aggregate node to
> Flink user functions. As hash-based combiner is not available yet(see PR
> #1517), we would use sort-based combine as default.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
